Skip to content

Commit

Permalink
remove outdated TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
andreaTP committed Sep 25, 2024
1 parent 3bff505 commit 47a5a15
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions aot/src/main/java/com/dylibso/chicory/aot/AotMethods.java
Original file line number Diff line number Diff line change
Expand Up @@ -175,17 +175,13 @@ public static long[] callIndirect(
throw new ChicoryException("uninitialized element " + funcTableIdx);
}

// TODO: this check can be performed statically, I guess
FunctionType expectedType = instance.type(typeId);
FunctionType actualType = instance.type(instance.functionType(funcId));
if (!actualType.typesMatch(expectedType)) {
throw new ChicoryException("indirect call type mismatch");
}

checkInterruption();
// TODO: verify
// here we should not pass through the external "call" method
// but directly emit the invocation of the underlying function
return instance.getMachine().call(funcId, args);
}

Expand Down

0 comments on commit 47a5a15

Please sign in to comment.