Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polymarket): add dismissable reducer and fix ticker #1128

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Oct 8, 2024

Miscellaneous fixes for Polymarket feature and long form tickers.


Views

  • <PredictionMarketIntroDialog>

    • Use dismissable slice to set hasSeenPredictionMarketIntroDialog
  • <CurrentMarketDetail>

    • Remove long form ticker

Hooks

  • hooks/useCurrentMarketId
    • use hasSeenPredictionMarketIntroDialog via useAppSelector

State

  • new state/dismissable, state/_store

    • Add dismissable reducer/slice and add to redux-persist
    • Add dismissableSelectors
    • Use for hasSeenPredictionMarketIntroDialog to replace useLocalStorage
  • new state/migration2

    • migrate localStorage to redux persist

@jaredvu jaredvu requested a review from a team as a code owner October 8, 2024 12:28
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 6:00pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 6:00pm

src/hooks/useCurrentMarketId.ts Outdated Show resolved Hide resolved
src/constants/localStorage.ts Show resolved Hide resolved
@rosepuppy rosepuppy merged commit dded7ef into main Oct 8, 2024
9 checks passed
@rosepuppy rosepuppy deleted the jv/polymarket-nits branch October 8, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants