[OTE-618] enable msk partition level logging for mainnet #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryfan01234
requested review from
jiajames,
vincentwschau and
Christopher-Li
as code owners
jerryfan01234
force-pushed
the
msk-logging-change
branch
from
38e0ae5
to
7e028ef
Compare
jerryfan01234
changed the title
indexer/msk.tf
Outdated
| @@ -24,6 +24,7 @@ resource "aws_msk_cluster" "main" { | |||
| cluster_name = "${var.environment}-${var.indexers[var.region].name}-msk-cluster" | |||
| kafka_version = local.kafka_version | |||
| number_of_broker_nodes = 3 | |||
| enhanced_monitoring = var.environment == "mainnet" ? "PER_TOPIC_PER_PARTITION" : "DEFAULT" | |||
There was a problem hiding this comment.
nit: mainnet and testnet
jerryfan01234
force-pushed
the
msk-logging-change
branch
from
123f492
to
53e1009
Compare
jerryfan01234
force-pushed
the
msk-logging-change
branch
from
53e1009
to
b3d6a0a
Compare
jerryfan01234
force-pushed
the
msk-logging-change
branch
from
bc78b90
to
d86d0ab
Compare
Christopher-Li
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.