filling in trading sections #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewdowney
requested changes
May 22, 2024
| @@ -32,8 +32,30 @@ These are orders which have a finite lifetime and are valid for a short period o | |||
|
|
|||
| All the below orders are transactions and are signed. The client[4](https://docs.dydx.exchange/developers/clients/validator_client) can be used or the transaction can be placed manually by following conforming to the formats specified here[5](https://github.com/dydxprotocol/v4-chain/blob/main/proto/dydxprotocol/clob/tx.proto). For manual transactions, the transaction can be signed using the following documentation[6](https://docs.cosmos.network/v0.50/user/run-node/txs). | |||
| #### Place | |||
| To place an order, refer to the proto here[7](https://github.com/dydxprotocol/v4-chain/blob/main/proto/dydxprotocol/clob/tx.proto#L27) to understand the parameters required. | |||
There was a problem hiding this comment.
Think this could use more detail. Once you build the order proto, what do you do with it? Does it go inside another proto? How to sign it? Where to broadcast it? (I think there's a REST endpoint for this too, just like the other full node endpoints.)
It's okay if we don't show them how step by step, but it would be great if a reader could read this section and follow links to everything they need to implement this in whatever language they're using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.