Revert "Emergency patch to handle invalid TimeInForce. (#942)"

[dydxwill]

This reverts commit 7a027e4.

Changelist

Revert "Emergency patch to handle invalid TimeInForce. (#942)"
Order validation is now being done in the protocol.

Test Plan

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[coderabbitai]

Walkthrough

The recent updates across several modules and tests indicate a shift away from handling emergency patches for unexpected TimeInForce (TIF) values. The system is now standardized to throw errors when it encounters any unrecognized TIF inputs. This suggests a move towards stricter input validation and error handling, likely to ensure more predictable and secure operations within the system's order processing logic.

Changes

File Path	Change Summary
indexer/.../protocol-translations.test.ts indexer/services/ender/.../order-handler.test.ts	Removed test cases for emergency patches and reactivated a test case to expect an error on unrecognized protocolTIF.
indexer/.../protocol-translations.ts	Modified to throw an error for unexpected TimeInForce inputs, removing the emergency patch logic.
indexer/services/ender/.../dydx_from_protocol_time_in_force.sql	Updated to raise an exception for unexpected time-in-force values, with the "GTT" case removed.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7a027e4 and eee6900.

Files selected for processing (4)

• indexer/packages/postgres/tests/lib/protocol-translations.test.ts (2 hunks)
• indexer/packages/postgres/src/lib/protocol-translations.ts (1 hunks)
• indexer/services/ender/tests/handlers/order-fills/order-handler.test.ts (1 hunks)
• indexer/services/ender/src/scripts/helpers/dydx_from_protocol_time_in_force.sql (1 hunks)

Files skipped from review due to trivial changes (1)

• indexer/services/ender/tests/handlers/order-fills/order-handler.test.ts

Additional comments: 3

indexer/services/ender/src/scripts/helpers/dydx_from_protocol_time_in_force.sql (1)

• 17-17: The change to raise an exception for unexpected TimeInForce values aligns with the PR objectives to revert the emergency patch and rely on protocol-level validation. Ensure that all calling code is updated to handle this new exception.

indexer/packages/postgres/__tests__/lib/protocol-translations.test.ts (1)

• 179-185: Reactivating the test case to expect an exception for unrecognized TimeInForce values is correct and aligns with the changes made to the protocolOrderTIFToTIF function.

indexer/packages/postgres/src/lib/protocol-translations.ts (1)

• 278-278: The modification to the protocolOrderTIFToTIF function to throw an error for unexpected TimeInForce values is correct and aligns with the PR objectives to revert the emergency patch.