Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency patch to handle invalid TimeInForce. #907

Merged
merged 5 commits into from
Dec 30, 2023

Conversation

vincentwschau
Copy link
Contributor

Changelist

Emergency patch to handle invalid TimeInForce value of 4 in block 4686923.

Test Plan

Tested on internal mainnet indexer.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Copy link
Contributor

coderabbitai bot commented Dec 30, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@vincentwschau vincentwschau changed the title [DO NOT MERGE] Emergency patch to handle invalid TimeInForce. Emergency patch to handle invalid TimeInForce. Dec 30, 2023
@vincentwschau vincentwschau merged commit d79cb5a into release/indexer/v1.x Dec 30, 2023
11 checks passed
@vincentwschau vincentwschau deleted the vincentc/patch-ender-tif-4 branch December 30, 2023 20:07
dydxwill added a commit that referenced this pull request Jan 9, 2024
* Emergency patch to handle invalid TimeInForce. (#907)

---------

Co-authored-by: vincentwschau <[email protected]>
dydxwill added a commit that referenced this pull request Jan 9, 2024
* Emergency patch to handle invalid TimeInForce. (#907)

---------

Co-authored-by: vincentwschau <[email protected]>
@roy-dydx
Copy link
Contributor

roy-dydx commented Jan 9, 2024

@Mergifyio backport release/indexer/v3.x

Copy link
Contributor

mergify bot commented Jan 9, 2024

backport release/indexer/v3.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 9, 2024
(cherry picked from commit d79cb5a)

# Conflicts:
#	indexer/services/ender/src/scripts/dydx_from_protocol_time_in_force.sql
dydxwill added a commit that referenced this pull request Jan 9, 2024
* Emergency patch to handle invalid TimeInForce. (#907)

---------

Co-authored-by: vincentwschau <[email protected]>
dydxwill added a commit that referenced this pull request Jan 9, 2024
* Emergency patch to handle invalid TimeInForce. (#907)

---------

Co-authored-by: vincentwschau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants