Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auxo build and add auxo build check #2140

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix auxo build and add auxo build check #2140

merged 1 commit into from
Aug 22, 2024

Conversation

roy-dydx
Copy link
Contributor

@roy-dydx roy-dydx commented Aug 22, 2024

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Introduced a new CI/CD workflow job for enhanced automated checks and builds for the Auxo project.
    • Updated Docker image build process to include necessary development packages from additional directories.
  • Improvements

    • Improved overall workflow efficiency by incorporating new build and dependency management steps.

@roy-dydx roy-dydx requested a review from a team as a code owner August 22, 2024 16:38
Copy link
Contributor

coderabbitai bot commented Aug 22, 2024

Walkthrough

The changes introduce a new job in the GitHub Actions workflow for the auxo project, which runs on ubuntu-latest. This job includes steps for checking out the repository, installing Node.js and pnpm, and executing a production build before building a Docker image. Additionally, the Dockerfile is updated to include several directories from the packages folder, enhancing the build process.

Changes

Files Change Summary
.github/workflows/indexer-build-docker-image-check.yml New job check-build-auxo added to automate build checks and Docker image creation for auxo.
indexer/Dockerfile.auxo.remote Added commands to copy the dev, postgres, kafka, and redis directories from packages into the Docker image.

Sequence Diagram(s)

Poem

🐰 In the land of code where the rabbits play,
New jobs and Docker come out to stay!
With pnpm and Node, they build and they thrive,
Including the dev to keep dreams alive!
Hopping along in a seamless delight,
Our workflow is better, oh what a sight! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 76bd1c8 and fd0b340.

Files selected for processing (2)
  • .github/workflows/indexer-build-docker-image-check.yml (1 hunks)
  • indexer/Dockerfile.auxo.remote (1 hunks)
Additional comments not posted (2)
indexer/Dockerfile.auxo.remote (1)

14-14: Verify the necessity of including the dev directory.

Including the dev directory in the Docker image might increase the image size unnecessarily if it contains development-only dependencies or scripts. Ensure that its inclusion is essential for the production environment.

.github/workflows/indexer-build-docker-image-check.yml (1)

81-109: LGTM! Verify the job configuration.

The check-build-auxo job is well-structured and consistent with other jobs in the workflow. Ensure that the job configuration aligns with the intended build and deployment processes.

@roy-dydx roy-dydx force-pushed the roy/auxobuild branch 2 times, most recently from a394450 to c153dde Compare August 22, 2024 16:44
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fd0b340 and fbff4a7.

Files selected for processing (2)
  • .github/workflows/indexer-build-docker-image-check.yml (1 hunks)
  • indexer/Dockerfile.auxo.remote (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/indexer-build-docker-image-check.yml
  • indexer/Dockerfile.auxo.remote

@roy-dydx roy-dydx merged commit 431c69b into main Aug 22, 2024
16 checks passed
@roy-dydx roy-dydx deleted the roy/auxobuild branch August 22, 2024 17:26
@roy-dydx
Copy link
Contributor Author

@Mergifyio backport release/indexer/v5.x

Copy link
Contributor

mergify bot commented Aug 23, 2024

backport release/indexer/v5.x

✅ Backports have been created

@roy-dydx
Copy link
Contributor Author

https://github.com/Mergifyio backport release/indexer/v6.x

Copy link
Contributor

mergify bot commented Aug 23, 2024

backport release/indexer/v6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 23, 2024
mergify bot pushed a commit that referenced this pull request Aug 23, 2024
roy-dydx added a commit that referenced this pull request Aug 23, 2024
roy-dydx added a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants