-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix auxo build and add auxo build check #2140
Conversation
WalkthroughThe changes introduce a new job in the GitHub Actions workflow for the Changes
Sequence Diagram(s)
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/indexer-build-docker-image-check.yml (1 hunks)
- indexer/Dockerfile.auxo.remote (1 hunks)
Additional comments not posted (2)
indexer/Dockerfile.auxo.remote (1)
14-14
: Verify the necessity of including thedev
directory.Including the
dev
directory in the Docker image might increase the image size unnecessarily if it contains development-only dependencies or scripts. Ensure that its inclusion is essential for the production environment..github/workflows/indexer-build-docker-image-check.yml (1)
81-109
: LGTM! Verify the job configuration.The
check-build-auxo
job is well-structured and consistent with other jobs in the workflow. Ensure that the job configuration aligns with the intended build and deployment processes.
a394450
to
c153dde
Compare
c153dde
to
fbff4a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/indexer-build-docker-image-check.yml (1 hunks)
- indexer/Dockerfile.auxo.remote (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/indexer-build-docker-image-check.yml
- indexer/Dockerfile.auxo.remote
@Mergifyio backport release/indexer/v5.x |
✅ Backports have been created
|
https://github.com/Mergifyio backport release/indexer/v6.x |
✅ Backports have been created
|
(cherry picked from commit 431c69b)
(cherry picked from commit 431c69b)
Co-authored-by: roy-dydx <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
Changelist
[Describe or list the changes made in this PR]
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.Summary by CodeRabbit
New Features
Improvements