-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable username generation roundtable task #2126
Conversation
WalkthroughThe recent change involved updating the configuration schema in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- indexer/services/roundtable/src/config.ts (1 hunks)
Additional comments not posted (1)
indexer/services/roundtable/src/config.ts (1)
54-54
: Verify the impact of disabling the username generator by default.The default value for
LOOPS_ENABLED_SUBACCOUNT_USERNAME_GENERATOR
has been changed tofalse
. This will disable the subaccount username generator unless explicitly enabled. Ensure that this change aligns with the application's requirements and does not inadvertently affect user experience or functionality.Run the following script to verify where and how
LOOPS_ENABLED_SUBACCOUNT_USERNAME_GENERATOR
is used in the codebase:
https://github.com/Mergifyio backport release/indexer/v6.x |
✅ Backports have been created
|
(cherry picked from commit c2099b9) # Conflicts: # indexer/services/roundtable/src/config.ts
Changelist
Disables username generation until we come up with a better approach
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.Summary by CodeRabbit
New Features
Impact