fix test

dydxprotocol · Sep 30, 2024 · 4095af9 · 4095af9
1 parent c5cee6e
commit 4095af9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/indexer/packages/v4-protos/src/codegen/dydxprotocol/clob/order_removals.ts b/indexer/packages/v4-protos/src/codegen/dydxprotocol/clob/order_removals.ts
@@ -67,8 +67,8 @@ export enum OrderRemoval_RemovalReason {
   REMOVAL_REASON_VIOLATES_ISOLATED_SUBACCOUNT_CONSTRAINTS = 8,
 
   /**
-   * REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED - REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED represents a removal of an order that
-   * was placed using an expired permissioned key.
+   * REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED - REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED represents a removal of an order
+   * that was placed using an expired permissioned key.
    */
   REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED = 9,
   UNRECOGNIZED = -1,
@@ -139,8 +139,8 @@ export enum OrderRemoval_RemovalReasonSDKType {
   REMOVAL_REASON_VIOLATES_ISOLATED_SUBACCOUNT_CONSTRAINTS = 8,
 
   /**
-   * REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED - REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED represents a removal of an order that
-   * was placed using an expired permissioned key.
+   * REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED - REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED represents a removal of an order
+   * that was placed using an expired permissioned key.
    */
   REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED = 9,
   UNRECOGNIZED = -1,

diff --git a/proto/dydxprotocol/clob/order_removals.proto b/proto/dydxprotocol/clob/order_removals.proto
@@ -48,8 +48,8 @@ message OrderRemoval {
     // REMOVAL_REASON_FULLY_FILLED represents a removal of an order that
     //  would lead to the subaccount violating isolated subaccount constraints.
     REMOVAL_REASON_VIOLATES_ISOLATED_SUBACCOUNT_CONSTRAINTS = 8;
-    // REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED represents a removal of an order that
-    // was placed using an expired permissioned key.
+    // REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED represents a removal of an order
+    // that was placed using an expired permissioned key.
     REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED = 9;
   }
 

diff --git a/protocol/indexer/shared/order_removal_reason.go b/protocol/indexer/shared/order_removal_reason.go
@@ -31,6 +31,8 @@ func ConvertOrderRemovalReasonToIndexerOrderRemovalReason(
 	case clobtypes.OrderRemoval_REMOVAL_REASON_VIOLATES_ISOLATED_SUBACCOUNT_CONSTRAINTS:
 		reason = sharedtypes.OrderRemovalReason_ORDER_REMOVAL_REASON_VIOLATES_ISOLATED_SUBACCOUNT_CONSTRAINTS
 	case clobtypes.OrderRemoval_REMOVAL_REASON_PERMISSIONED_KEY_EXPIRED:
+		// This is a special case where the order is no longer valid because the permissioned key used to placed
+		// the order has expired.
 		reason = sharedtypes.OrderRemovalReason_ORDER_REMOVAL_REASON_EXPIRED
 	default:
 		panic("ConvertOrderRemovalReasonToIndexerOrderRemovalReason: unspecified removal reason not allowed")

diff --git a/protocol/x/clob/types/order_removals.pb.go b/protocol/x/clob/types/order_removals.pb.go