[IND-481] Delete price cache in ender. (#815)

More clean-up before migration to SQL based block processor.
dydxprotocol · Nov 29, 2023 · 3f5d937 · 3f5d937
1 parent 26938c8
commit 3f5d937
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 210 deletions.
diff --git a/indexer/services/ender/__tests__/caches/block-cache.test.ts b/indexer/services/ender/__tests__/caches/block-cache.test.ts
@@ -17,7 +17,6 @@ import {
   shouldSkipBlock,
 } from '../../src/caches/block-cache';
 import { clearCandlesMap, getCandlesMap } from '../../src/caches/candle-cache';
-import { clearPriceMap, getPriceMap } from '../../src/caches/price-cache';
 
 describe('block-cache', () => {
   beforeAll(async () => {
@@ -34,7 +33,6 @@ describe('block-cache', () => {
     await dbHelpers.clearData();
     resetBlockCache();
     clearCandlesMap();
-    clearPriceMap();
     perpetualMarketRefresher.clear();
     assetRefresher.clear();
     marketRefresher.clear();
@@ -80,7 +78,6 @@ describe('block-cache', () => {
         // validate that block, candles, and price cache are updated
         expect(getCurrentBlockHeight()).toEqual('3');
         expect(getCandlesMap()).not.toEqual({});
-        expect(getPriceMap()).not.toEqual({});
         expect(perpetualMarketRefresher.getPerpetualMarketsMap()).not.toEqual({});
         expect(assetRefresher.getAssetsMap()).not.toEqual({});
         expect(marketRefresher.getMarketsMap()).not.toEqual({});
@@ -93,7 +90,6 @@ describe('block-cache', () => {
       // Validate that caches are empty
       expect(getCurrentBlockHeight()).toEqual('-1');
       expect(getCandlesMap()).toEqual({});
-      expect(getPriceMap()).toEqual({});
       expect(perpetualMarketRefresher.getPerpetualMarketsMap()).toEqual({});
       expect(assetRefresher.getAssetsMap()).toEqual({});
       expect(marketRefresher.getMarketsMap()).toEqual({});
@@ -103,7 +99,6 @@ describe('block-cache', () => {
       // Validate that caches are populated
       expect(getCurrentBlockHeight()).toEqual('2');
       expect(getCandlesMap()).not.toEqual({});
-      expect(getPriceMap()).not.toEqual({});
       expect(perpetualMarketRefresher.getPerpetualMarketsMap()).not.toEqual({});
       expect(assetRefresher.getAssetsMap()).not.toEqual({});
       expect(marketRefresher.getMarketsMap()).not.toEqual({});

diff --git a/indexer/services/ender/__tests__/caches/price-cache.test.ts b/indexer/services/ender/__tests__/caches/price-cache.test.ts
diff --git a/indexer/services/ender/__tests__/handlers/funding-handler.test.ts b/indexer/services/ender/__tests__/handlers/funding-handler.test.ts
@@ -39,7 +39,6 @@ import { redis } from '@dydxprotocol-indexer/redis';
 import Big from 'big.js';
 import { redisClient } from '../../src/helpers/redis/redis-controller';
 import { bigIntToBytes } from '@dydxprotocol-indexer/v4-proto-parser';
-import { startPriceCache } from '../../src/caches/price-cache';
 import { createPostgresFunctions } from '../../src/helpers/postgres/postgres-functions';
 
 describe('fundingHandler', () => {
@@ -57,7 +56,6 @@ describe('fundingHandler', () => {
     await perpetualMarketRefresher.updatePerpetualMarkets();
     await assetRefresher.updateAssets();
     updateBlockCache(defaultPreviousHeight);
-    await startPriceCache(defaultPreviousHeight);
   });
 
   afterEach(async () => {

diff --git a/indexer/services/ender/__tests__/handlers/markets/market-price-update-handler.test.ts b/indexer/services/ender/__tests__/handlers/markets/market-price-update-handler.test.ts
@@ -31,7 +31,6 @@ import { updateBlockCache } from '../../../src/caches/block-cache';
 import { MarketEventV1, IndexerTendermintBlock, IndexerTendermintEvent } from '@dydxprotocol-indexer/v4-protos';
 import { MarketPriceUpdateHandler } from '../../../src/handlers/markets/market-price-update-handler';
 import Long from 'long';
-import { getPrice } from '../../../src/caches/price-cache';
 import { createPostgresFunctions } from '../../../src/helpers/postgres/postgres-functions';
 
 describe('marketPriceUpdateHandler', () => {
@@ -148,8 +147,6 @@ describe('marketPriceUpdateHandler', () => {
       defaultHeight,
     );
 
-    expect(getPrice(oraclePrice.marketId)).toEqual(oraclePrice.price);
-
     const contents: MarketMessageContents = generateOraclePriceContents(
       oraclePrice,
       market.pair,
@@ -202,8 +199,6 @@ describe('marketPriceUpdateHandler', () => {
       defaultHeight,
     );
 
-    expect(getPrice(oraclePrice.marketId)).toEqual(oraclePrice.price);
-
     const contents: MarketMessageContents = generateOraclePriceContents(
       oraclePrice,
       market.pair,

diff --git a/indexer/services/ender/src/caches/block-cache.ts b/indexer/services/ender/src/caches/block-cache.ts
@@ -12,7 +12,6 @@ import Big from 'big.js';
 
 import config from '../config';
 import { startCandleCache } from './candle-cache';
-import { startPriceCache } from './price-cache';
 
 const INITIAL_BLOCK_HEIGHT: string = '-1';
 
@@ -114,8 +113,6 @@ export async function initializeAllCaches(): Promise<void> {
     assetRefresher.updateAssets({ txId }),
     marketRefresher.updateMarkets({ txId }),
   ]);
-  // Must be run after startBlockCache() because it uses the block cache.
-  await startPriceCache(getCurrentBlockHeight(), txId);
 
   await Transaction.rollback(txId);
 }

diff --git a/indexer/services/ender/src/caches/price-cache.ts b/indexer/services/ender/src/caches/price-cache.ts
diff --git a/indexer/services/ender/src/handlers/markets/market-price-update-handler.ts b/indexer/services/ender/src/handlers/markets/market-price-update-handler.ts
@@ -8,7 +8,6 @@ import {
 import { MarketEventV1 } from '@dydxprotocol-indexer/v4-protos';
 import * as pg from 'pg';
 
-import { updatePriceCacheWithPrice } from '../../caches/price-cache';
 import { generateOraclePriceContents } from '../../helpers/kafka-helper';
 import {
   ConsolidatedKafkaEvent,
@@ -64,7 +63,6 @@ export class MarketPriceUpdateHandler extends Handler<MarketEventV1> {
       result.rows[0].result.oracle_price) as OraclePriceFromDatabase;
 
     marketRefresher.updateMarket(market);
-    updatePriceCacheWithPrice(oraclePrice);
 
     return [
       this.generateKafkaEvent(