Skip to content

Commit

Permalink
Remove sortByOpenPr function
Browse files Browse the repository at this point in the history
Now we have the more generic sortByNumericValue function we  no longer
use sortByOpenPr so it can be removed.
  • Loading branch information
rich committed Sep 13, 2024
1 parent 00cc36c commit f22cb16
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 61 deletions.
14 changes: 0 additions & 14 deletions utils/sorting.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,6 @@
* @property {"desc"} DESC
*/

/**
* Sorts repos by the number of open PRs
* @param {UiRepo[]} repos
* @param {SortDirection} sortDirection
* @returns {UiRepo[]}
*/
export const sortByOpenPrs = (repos, sortDirection) => {
if (!sortDirection) return repos;
if (sortDirection === "asc") {
return repos.sort((a, b) => a.openPrsCount - b.openPrsCount);
}
return repos.sort((a, b) => b.openPrsCount - a.openPrsCount);
};

/**
* Sorts repos by the a numeric value
* @param {UiRepo[]} repos
Expand Down
48 changes: 1 addition & 47 deletions utils/sorting.test.js
Original file line number Diff line number Diff line change
@@ -1,52 +1,6 @@
import { describe, it } from "node:test";
import expect from "node:assert";
import { sortByOpenPrs, sortByNumericValue, sortByType } from "./sorting.js";

describe("sortByOpenPrs", () => {
it("returns the original array if sortDirection is not provided", () => {
const repos = [
{ name: "Repo 1", openPrsCount: 5 },
{ name: "Repo 2", openPrsCount: 3 },
{ name: "Repo 3", openPrsCount: 7 },
];

const result = sortByOpenPrs(repos);

expect.deepEqual(result, repos);
});

it("sorts the array in ascending order by openPrsCount if sortDirection is 'asc'", () => {
const repos = [
{ name: "Repo 1", openPrsCount: 5 },
{ name: "Repo 2", openPrsCount: 3 },
{ name: "Repo 3", openPrsCount: 7 },
];

const result = sortByOpenPrs(repos, "asc");

expect.deepEqual(result, [
{ name: "Repo 2", openPrsCount: 3 },
{ name: "Repo 1", openPrsCount: 5 },
{ name: "Repo 3", openPrsCount: 7 },
]);
});

it("sorts the array in descending order by openPrsCount if sortDirection is 'desc'", () => {
const repos = [
{ name: "Repo 1", openPrsCount: 5 },
{ name: "Repo 2", openPrsCount: 3 },
{ name: "Repo 3", openPrsCount: 7 },
];

const result = sortByOpenPrs(repos, "desc");

expect.deepEqual(result, [
{ name: "Repo 3", openPrsCount: 7 },
{ name: "Repo 1", openPrsCount: 5 },
{ name: "Repo 2", openPrsCount: 3 },
]);
});
});
import { sortByNumericValue, sortByType } from "./sorting.js";

describe("sortByNumericValue", () => {
it("returns the original array if sortDirection is not provided", () => {
Expand Down

0 comments on commit f22cb16

Please sign in to comment.