Enforce references for whippet dependencies #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the work to automate plugin updates, we want to ensure that we don't accidentally deploy a breaking change when running `whippet deps update`. The best way to do this currently is to pin all plugins to a specific git reference (normally the major version tag for the current release). This change ensures that the workflow will fail if a file in `whippet.json` does not have a reference specified. See dxw/whippet#245 for where this feature was added to Whippet.
snim2
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work to automate plugin updates, we want to ensure that we don't accidentally deploy a breaking change when running
whippet deps update. The best way to do this currently is to pin all plugins to a specific git reference (normally the major version tag for the current release).This change ensures that the workflow will fail if a file in
whippet.jsondoes not have a reference specified.See dxw/whippet#245 for where this feature was added to Whippet.