[WIP] Improve the codebase and along with downloads #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing. @tbhaxor Can you check what's wrong? |
|
I am working on the fix, will open it for review once all is done. |
|
Okay! |
tbhaxor
force-pushed
the
improve/download
branch
6 times, most recently
from
3af4a8d
to
5187e53
Compare
|
The test in one of the fails is because the ionization is not giving the correct output. Ionization fraction has been called with a random element, and no ion argument has been passed. So, it will now generate all the ions for the chosen element, i.e., |
Simplified the cooltable.dat loading and validate ndarray dimensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.