Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and rename Scalar::from_bytes_wide #138

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

moCello
Copy link
Member

@moCello moCello commented Dec 5, 2023

It now used a 512-bit large destination string to hash into. New name: from_blake2b hash_to_scalar.

Resolves #137

src/scalar/dusk.rs Outdated Show resolved Hide resolved
src/scalar/dusk.rs Outdated Show resolved Hide resolved
src/scalar/dusk.rs Show resolved Hide resolved
@moCello moCello force-pushed the mocello/from_blake2b branch 2 times, most recently from ba307b3 to a99a91b Compare December 5, 2023 13:03
@moCello moCello requested a review from vlopes11 December 5, 2023 13:06
Copy link

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Consider also the name hash_to_field

@moCello
Copy link
Member Author

moCello commented Dec 5, 2023

unfortunately the name hash_to_field is already in use in the hash_to_curve module.

It now used a 512-bit large destination string to hash into.
New name: `hash_to_scalar`.

Resolves #137
Co-authored_by: Victor Lopez <[email protected]>
@moCello moCello merged commit 69548a7 into master Dec 5, 2023
@moCello moCello deleted the mocello/from_blake2b branch December 5, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor and rename Scalar::from_var_bytes
2 participants