Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker container did not build issue-890 #892

Merged
merged 1 commit into from
Dec 5, 2021
Merged

fix: docker container did not build issue-890 #892

merged 1 commit into from
Dec 5, 2021

Conversation

chrisjohnson00
Copy link
Contributor

This should fix the problems I outlined in issue #890

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@w0rmr1d3r w0rmr1d3r mentioned this pull request Sep 8, 2021
Open
gregorycoleman
gregorycoleman reviewed Oct 14, 2021
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
gregorycoleman
gregorycoleman suggested changes Oct 14, 2021
View reviewed changes
Copy link

@gregorycoleman gregorycoleman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change urllib3==1.26.5 to urllib3 instead of removing

@chrisjohnson00
Copy link
Contributor Author

@gregorycoleman - for some reason GH won't allow me to use the re-request button... nothing happens, so please re-review at your convenience.

0xdabbad00
0xdabbad00 reviewed Nov 3, 2021
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@chrisjohnson00
Copy link
Contributor Author

Ready for re-review, but the re-review button is disabled ;)

@ejohn20 ejohn20 mentioned this pull request Dec 5, 2021
Open
@0xdabbad00 0xdabbad00 merged commit 21136e8 into duo-labs:main Dec 5, 2021
@0xdabbad00
Copy link
Collaborator

Thank you @chrisjohnson00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdabbad00 0xdabbad00 0xdabbad00 left review comments

@gregorycoleman gregorycoleman gregorycoleman requested changes

@tudorghigheanu tudorghigheanu tudorghigheanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisjohnson00 @CLAassistant @0xdabbad00 @gregorycoleman @tudorghigheanu