Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP4 : API to upload target dataset #19

Open
duncanpeacock opened this issue Oct 8, 2020 · 8 comments
Open

WP4 : API to upload target dataset #19

duncanpeacock opened this issue Oct 8, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request High Priority

Comments

@duncanpeacock
Copy link
Owner

Add an Upload page to the Fragalyis backend that allows a zip file of Target datasets to be uploaded. The code/process will be based on the existing upload code for Compound_csets in the fragalysis_backend using a Celery async process.

Look at removing visits+proposals from upload directory.

Parent Issue (xchem#208)

@duncanpeacock duncanpeacock added enhancement New feature or request High Priority labels Oct 8, 2020
@duncanpeacock duncanpeacock self-assigned this Oct 8, 2020
@duncanpeacock
Copy link
Owner Author

Initial discussion with Rachael.

  1. Initial Target is to supply a method to update a Target dataset in a zip file.
  2. There is an existing process for Compound Sets that can be used as a model for the new upload process. It has a separate page rendered ( viewer/upload_cset/ ). See: ( https://fragalysis.diamond.ac.uk/viewer/upload_cset/ )
  3. Snapshot breaking problem notes:
  • This has been worked on – it now no longer deletes and re-adds everything – changed by Rachael to update rather than overwrite. However it still seems to "break" snapshots. We discussed some theories that I can test as part of the process.
  • Not as high priority as the API because of Boris' work on recreating snapshots from history.

Currently working on an initial analysis/design.

@duncanpeacock duncanpeacock changed the title WP4 : API to upload target data WP4 : API to upload target dataset Oct 9, 2020
@duncanpeacock
Copy link
Owner Author

duncanpeacock commented Oct 14, 2020

First version of design document for review:
Loader API Change WP4 v0.1.docx

@duncanpeacock
Copy link
Owner Author

Second version of change document:
Principal changes:

  • Expanded authentication section - investigation of current authentication/authorisation processes in the fragalysis backend and recommendations for improvements.
  • proposal/visit now included
  • configuration of proposal/visit for different users

Loader API Change WP4 v0.2.docx

@duncanpeacock
Copy link
Owner Author

Agreed to split wider authentication/authorisation question into separate issue/sprint.
Coding started on first version.

@duncanpeacock
Copy link
Owner Author

Coding continuing

  • Code migrated across and basic page running (but fragile) with downloaded structures. However this is not the end state as the code will not come from this source - should match closely the input data from loader.

Next stages (for this sprint):

  1. Fix compound results page (had to break this for the above)
  2. Tidy code
  3. Get working with 'real' input data
  4. Proposals+Visits (public data)
  5. Test with compound sets
  6. Add authentication

@duncanpeacock
Copy link
Owner Author

Initial version of API working on: fragalysis-duncan-default.xchem-dev.diamond.ac.uk/
Remaining to do for Minimum viable product:

  1. Validation of results (Rachael taking a look at this) - and anything changes following from that.
  2. Basic authentication (check on html page that user is logged in)
  3. Small bug fixes (create tmp folder when missing, tidy up data when validation fails)

@duncanpeacock
Copy link
Owner Author

Authentication and bug fixes done.

@duncanpeacock
Copy link
Owner Author

Review, Pull request made and accepted. Separate issue created as place holder for follow up work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High Priority
Projects
None yet
Development

No branches or pull requests

1 participant