Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP4: Support - Json Object State #16

Open
duncanpeacock opened this issue Sep 18, 2020 · 3 comments
Open

WP4: Support - Json Object State #16

duncanpeacock opened this issue Sep 18, 2020 · 3 comments
Assignees
Labels
bug Something isn't working Low Priority

Comments

@duncanpeacock
Copy link
Owner

Description

Investigate loader (xchem/fragalysis-loader) issues - db keys changing when data updated. Identify / Fix issues where necessary / possible.

Deliverables

Solution / Issues Raised

Parent: (xchem#208)

@duncanpeacock duncanpeacock added bug Something isn't working High Priority labels Sep 18, 2020
@duncanpeacock duncanpeacock self-assigned this Sep 18, 2020
@duncanpeacock
Copy link
Owner Author

Arranged a meeting with Tyler for initial walkthrough / steps to recreate issue.

@duncanpeacock
Copy link
Owner Author

Some notes/initial ideas following the meeting with Tyler:

  • Data loads are done with production-media-loader from AWX with namespace production-stack.
  • Tyler thinks that it does delete and re-insert all data for the target set (and also suspects that the snapshots are probably broken because of auto-incrementing keys – I need to look at the code to see exactly what is going on.
  • Names can change – and naming conventions are not fixed - so using the name as a primary key is not sensible.
  • Maybe could use a SHA key as a hash on the contents of the file. If that hasn't changed then you could update the database rather than doing a delete/re-insert
  • Alternatively instead of deleting records, you could make them inactive (via setting a status and/or timestamp, say). That way, they could still be available for historical snapshots. Maybe this might also help the Error 404 loader issue that Boris was seeing. - Next step is look more closely at the code.

@duncanpeacock
Copy link
Owner Author

This has been lowered in priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Low Priority
Projects
None yet
Development

No branches or pull requests

1 participant