Fix identify_matches bug for when both NA or Inf log10LRs

duke-malaria-collaboratory · Sep 8, 2023 · 66badd5 · 66badd5
1 parent 1e941db
commit 66badd5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/R/identify_matches.R b/R/identify_matches.R
@@ -34,7 +34,7 @@ identify_one_match_set <- function(log10_lrs, bloodmeal_id) {
         "all log10LRs NA or Inf",
         paste0("all log10LRs NA or Inf", ";", notes)
       ))
-  } else if (max(log10_lrs$log10_lr[!is.infinite(log10_lrs$log10_lr)]) < 1.5 &&
+  } else if (max(log10_lrs$log10_lr[!is.na(log10_lrs$log10_lr) & !is.infinite(log10_lrs$log10_lr)]) < 1.5 &&
     is.na(notes)) {
     matches_thresh <- matches |>
       dplyr::mutate(notes = "all log10LRs < 1.5")

diff --git a/tests/testthat/test-identify_matches.R b/tests/testthat/test-identify_matches.R
@@ -15,6 +15,13 @@ test_that("identify_matches works", {
       )
     )
 
+  expect_no_error(identify_one_match_set(
+    lrs |>
+      dplyr::slice_head(n = 3) |>
+      dplyr::mutate(log10_lr = c(1, NA, Inf)),
+    "evid1"
+  ))
+
   expect_snapshot(identify_one_match_set(lrs, "evid1"))
 
   expect_snapshot(identify_one_match_set(lrs, "evid2"))