Fix bug in identify_one_match to handle Inf log10LRs

duke-malaria-collaboratory · Sep 6, 2023 · 48c5f86 · 48c5f86
1 parent e47fd28
commit 48c5f86
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/R/identify_matches.R b/R/identify_matches.R
@@ -28,7 +28,7 @@ identify_one_match_set <- function(log10_lrs, bloodmeal_id) {
     thresh_low = NA
   )
 
-  if (all(is.na(log10_lrs$log10_lr))) {
+  if (all(is.na(log10_lrs$log10_lr) | is.infinite(log10_lrs$log10_lr))) {
     matches_thresh <- matches
   } else if (max(log10_lrs$log10_lr[!is.infinite(log10_lrs$log10_lr)]) < 1.5 &&
     is.na(notes)) {

diff --git a/tests/testthat/test-identify_matches.R b/tests/testthat/test-identify_matches.R
@@ -32,4 +32,8 @@ test_that("identify_matches works", {
   )
 
   expect_snapshot(identify_matches(lrs))
+
+  expect_no_error(lrs |>
+    dplyr::mutate(log10_lr = Inf) |>
+    identify_matches())
 })