Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svgo to devDependencies and avoid removing viewBox #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented May 9, 2024

I thought this would help per the instructions in CONTRIBUTING.md. Note I didn't add svgo-viewbox because whenever I used it with an Inkscape image it would botch the size / viewBox. Instead, adding removeViewBox: false as an override of svgo via the svgo.config.mjs file (long complaint thread here) appears to work well.

@duerrsimon
Copy link
Owner

Thanks for the pull request. I am against merging it now since it just adds the dev dependency and I don't think many submitters actually clone the repo.
I plan to add a better pipeline that will process uploaded icons consistently removing also illustrator classes (there are a few offenders among the current icons).

@dcroote
Copy link
Contributor Author

dcroote commented May 16, 2024

I guess I don't know how your current or proposed processing pipeline is/will be implemented, but having svgo as a devDependency (along with the config file that prevents removal of the viewBox) would open up options to use it within a GitHub Actions workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants