-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable workflows + vcpkg in template #29
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review, will finish the rest in a bit, but looks strong.
samansmink
commented
Aug 11, 2023
This needs more work, I'll close this one for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: draft pr for reviewing purposes.
PR goals
vcpkg dependency in example extension
OpenSSL is now integrated in quack example extension to test/demonstrate vcpkg. What this means is that to build the example you can no longer "just build it", instead you need to either:
reusable workflows
The goal here is to no longer have all extensions have their own CI config, instead relying on remote workflows that is managed by us and can be updated to ensure all extensions can easily keep their CI up to date.
The main question here is, where should these workflows live? in a separate extension? in duckdb main repo? In the extension template itself? I think having them live either in a separate repo or in duckdb/duckdb makes the most sense.