Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable workflows + vcpkg in template #29

Closed
wants to merge 40 commits into from

Conversation

samansmink
Copy link
Collaborator

@samansmink samansmink commented Aug 4, 2023

Note: draft pr for reviewing purposes.

PR goals

  • integrate vcpkg into extension template
  • use reusable workflows
  • switch to using loadable extensions for client tests

vcpkg dependency in example extension

OpenSSL is now integrated in quack example extension to test/demonstrate vcpkg. What this means is that to build the example you can no longer "just build it", instead you need to either:

  • Use VCPKG
  • have OpenSSL installed already
  • remove the openssl part manually before building

reusable workflows

The goal here is to no longer have all extensions have their own CI config, instead relying on remote workflows that is managed by us and can be updated to ensure all extensions can easily keep their CI up to date.

The main question here is, where should these workflows live? in a separate extension? in duckdb main repo? In the extension template itself? I think having them live either in a separate repo or in duckdb/duckdb makes the most sense.

@samansmink samansmink requested a review from carlopi August 4, 2023 12:49
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, will finish the rest in a bit, but looks strong.

.github/workflows/MainDistributionPipeline.yml Outdated Show resolved Hide resolved
@samansmink
Copy link
Collaborator Author

This needs more work, I'll close this one for now

@samansmink samansmink closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants