Enable verification - add ORDER BY * #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to flag the state
…TILE function check to the GenerateFuntion() to be able to use not volatile functions if verification is enabled
…RY and AGGREGATE_FUNCTION_ENTRY generation flow - if it's VOLATILE, we just should pick non-volatile function (but I didn't see there any volatile func for now; Also the GenerateOrderBy() for now uses GenerateStar(), but in the test output I still see not only the ORDER BY * (ex. BY COLUMN 🤔). What's more, with the seed = 1 and enable_verification=true it crashes during the Query 21 on the 13th attempt of setop->left = GenerateQueryNode();
fix indentation
… places generating like Order by something (*) and fix it Add Generate Order by *, when verification is enabled. TODO: Find the places generating like Order by something (*) and fix it
…_enabled is false by default when StatementGenerator object created from (*this), its verification_enabled is false by default fix GenerateStarexpression to return only star expression, when verification_enabled=true fix GenerateStarexpression to return only star expression, when verification_enabled=true fix GenerateStarexpression to return only star expression, when verification_enabled=true clean up fix GenerateStarexpression to return only star expression, when verification_enabled=true
…ication_enabled=true fix GenerateStarexpression to return only star expression, when verification_enabled=true fix GenerateStarexpression to return only star expression, when verification_enabled=true fix GenerateStarexpression to return only star expression, when verification_enabled=true
hmeriann
force-pushed
the
enable-verification
branch
from
ba0ba08
to
5eb7801
Compare
|
@Tmonster could you please take a look at this PR? |
Tmonster
requested changes
Jul 22, 2024
src/statement_generator.cpp
Outdated
| @@ -532,6 +534,7 @@ unique_ptr<TableRef> StatementGenerator::GenerateSubqueryRef() { | |||
| unique_ptr<SelectStatement> subquery; | |||
| { | |||
| StatementGenerator child_generator(*this); | |||
There was a problem hiding this comment.
you can assign verification_enabled here in the constructor
There was a problem hiding this comment.
I created one more constructor to assign verification_enabled using it (and to avoid searching and adding the second parameter everywhere in the code).
remove commented out code
hmeriann
force-pushed
the
enable-verification
branch
from
67714f4
to
5ef9905
Compare
Tmonster
reviewed
Jul 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes StatementGenerator generate
ORDER BY *.It is the first step to fuzz with
enable_verification.Connected issue