Parse schema from table metadata #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to the 'read_parquet' function as schema for the result
Fokko
approved these changes
Nov 27, 2023
| auto digits = StringUtil::Split(raw_digits, ','); | ||
| D_ASSERT(digits.size() == 2); | ||
|
|
||
| auto width = std::stoi(digits[0]); |
There was a problem hiding this comment.
Checked if it strips whitespace and it looks like it does.
There was a problem hiding this comment.
So this is good as is right?
Tishj
reviewed
Nov 29, 2023
Tishj
reviewed
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we scan Iceberg tables. Before we would simply scan them as a list of parquet files, using the schema we found in the first parquet file scanned.
Now the iceberg metadata is actually scanned to parse the schema and pass that to the parquet_scan in duckdb using the
schemaparameter: duckdb/duckdb#9123This effectively adds support for schema evolution and resolves issues where the parquet schema is different from the iceberg schema.
To test it, the spark-based test data generation script was updated to include schema evolution. Note that it is not yet run from CI, but that will follow soon in conjunction with the REST catalog support and the testing infrastructure added in #27