Skip to content

Commit

Permalink
add some std::move() to appease the arm Linux compiler
Browse files Browse the repository at this point in the history
  • Loading branch information
Peter committed Oct 10, 2023
1 parent ca70abd commit 4545b44
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/iceberg_functions/iceberg_metadata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ static unique_ptr<FunctionData> IcebergMetaDataBind(ClientContext &context, Tabl
auto manifest_entry_names = IcebergManifestEntry::Names();
names.insert(names.end(), manifest_entry_names.begin(), manifest_entry_names.end());

return ret;
return std::move(ret);
}

static unique_ptr<FunctionData> IcebergScanBind(ClientContext &context, TableFunctionBindInput &input,
Expand Down Expand Up @@ -159,4 +159,4 @@ TableFunctionSet IcebergFunctions::GetIcebergMetadataFunction() {
return function_set;
}

} // namespace duckdb
} // namespace duckdb
4 changes: 2 additions & 2 deletions src/iceberg_functions/iceberg_scan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ static unique_ptr<TableRef> MakeScanExpression(vector<Value> &data_file_values,
vector<unique_ptr<ParsedExpression>> left_children;
left_children.push_back(make_uniq<ConstantExpression>(Value::LIST(data_file_values)));
table_function_ref_data->function = make_uniq<FunctionExpression>("parquet_scan", std::move(left_children));
return table_function_ref_data;
return std::move(table_function_ref_data);
}

// Join
Expand Down Expand Up @@ -250,4 +250,4 @@ TableFunctionSet IcebergFunctions::GetIcebergScanFunction() {
return function_set;
}

} // namespace duckdb
} // namespace duckdb
8 changes: 4 additions & 4 deletions src/iceberg_functions/iceberg_snapshots.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ struct IcebergSnapshotGlobalTableFunctionState : public GlobalTableFunctionState
global_state->iceberg_format_version = IcebergUtils::TryGetNumFromObject(root, "format-version");
auto snapshots = yyjson_obj_get(root, "snapshots");
yyjson_arr_iter_init(snapshots, &global_state->snapshot_it);
return global_state;
return std::move(global_state);
}

string metadata_file;
Expand All @@ -59,7 +59,7 @@ static unique_ptr<FunctionData> IcebergSnapshotsBind(ClientContext &context, Tab
names.emplace_back("manifest_list");
return_types.emplace_back(LogicalType::VARCHAR);

return bind_data;
return std::move(bind_data);
}

// Snapshots function
Expand Down Expand Up @@ -90,7 +90,7 @@ TableFunctionSet IcebergFunctions::GetIcebergSnapshotsFunction() {
TableFunction table_function({LogicalType::VARCHAR}, IcebergSnapshotsFunction, IcebergSnapshotsBind,
IcebergSnapshotGlobalTableFunctionState::Init);
function_set.AddFunction(table_function);
return function_set;
return std::move(function_set);
}

} // namespace duckdb
} // namespace duckdb

0 comments on commit 4545b44

Please sign in to comment.