Fix to build failure for duckdb_wasm sub-project test #1890
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is PR for issue #1888.
A test for
duckdb_wasm
sub-project has failed to build.It resolves this issue.
Out-of-scope
To build test artifact is success, but executing test still fails.
Following testcases:
AllTypesTest.FullRangeTypes
This test is used a udf
test_all_types
.It fails to not match expects columns with
test_all_types
columns.It will be easy modifying.
ParquetLoadTest.LoadParquet
In 1.29.0, DuckDB extensions support enabled by default.
So calling
duckdb_web_parquet_init(&db->database())
failes.It will be easy modifying. (line-delete only)
Same for the following
CSVExportTest.TestExport
This test fails calling
WebDB::Connection::InsertCSVFromPath
.But this method does not have a compression option.
It makes no sense for me.
FilePageBufferTest.FixSingle
It fails calling
TestableFilePageBuffer::BuffersFile
afterFilePageBuffer::FileRef::Release
.It seems that accessing released file buffer is incorrect.
It will need to make this specification clear.
And a artifact on built in debug mode let to be address sanitizer errors.
I can not resolve it.
A work around is built on release mode.