Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support list of strings for column references in R API #14

Conversation

Tmonster
Copy link
Contributor

Just moving this PR to duckdb-r
duckdb/duckdb#8730

@Tmonster Tmonster changed the title patch fix Support list of strings for column references in R API Sep 15, 2023
@krlmlr krlmlr force-pushed the support-list-of-strings-for-column-references-in-R-api branch from 912a88b to ddcf9ea Compare September 21, 2023 20:42
@krlmlr
Copy link
Collaborator

krlmlr commented Sep 27, 2023

Thanks. I need to see how this works with duckplyr.

@krlmlr krlmlr force-pushed the support-list-of-strings-for-column-references-in-R-api branch from 4cc5e2e to ea9b022 Compare October 11, 2023 19:27
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good exercise in backward compatibility!

@codecov-commenter
Copy link

Codecov Report

Merging #14 (d875ce7) into main (035ae0e) will increase coverage by 0.12%.
The diff coverage is 84.61%.

❗ Current head d875ce7 differs from pull request most recent head ea9b022. Consider uploading reports for the commit ea9b022 to get more accurate results

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   85.63%   85.75%   +0.12%     
==========================================
  Files         106      106              
  Lines        3598     3601       +3     
==========================================
+ Hits         3081     3088       +7     
+ Misses        517      513       -4     
Files Coverage Δ
R/relational.R 80.00% <75.00%> (-1.58%) ⬇️
src/relational.cpp 82.63% <88.88%> (-0.29%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@krlmlr krlmlr changed the title Support list of strings for column references in R API feat: Support list of strings for column references in R API Oct 11, 2023
@krlmlr krlmlr merged commit 4625214 into duckdb:main Oct 11, 2023
15 of 18 checks passed
@krlmlr
Copy link
Collaborator

krlmlr commented Oct 11, 2023

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants