owning the libs more

duckdb · May 2, 2024 · 8ce5ae9 · 8ce5ae9
1 parent dc031c0
commit 8ce5ae9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -31,9 +31,9 @@ if(ODBC_FOUND)
   endif()
 endif()
 
-
-if(NOT MSVC)
-  set(LIB_DL -ldl)
+set(DUCKDB_SYSTEM_LIBS ${CMAKE_DL_LIBS})
+if(MSVC)
+  set(DUCKDB_SYSTEM_LIBS ${DUCKDB_SYSTEM_LIBS} ws2_32 rstrtmgr bcrypt)
 endif()
 
 if(OSX_BUILD_UNIVERSAL)
@@ -52,7 +52,7 @@ add_library(duckdb_odbc SHARED ${ALL_OBJECT_FILES}  duckdb_odbc.def)
 
 set_target_properties(duckdb_odbc PROPERTIES DEFINE_SYMBOL "DUCKDB_ODBC_API")
 target_link_libraries(duckdb_odbc ${LINK_LIB_LIST} )
-target_link_libraries(duckdb_odbc Threads::Threads ${LIB_DL})
+target_link_libraries(duckdb_odbc Threads::Threads ${DUCKDB_SYSTEM_LIBS})
 
 if(NOT CLANG_TIDY)
   add_subdirectory(test)

diff --git a/CMakeLists.txt.in b/CMakeLists.txt.in
@@ -31,9 +31,9 @@ if(ODBC_FOUND)
   endif()
 endif()
 
-
-if(NOT MSVC)
-  set(LIB_DL -ldl)
+set(DUCKDB_SYSTEM_LIBS ${CMAKE_DL_LIBS})
+if(MSVC)
+  set(DUCKDB_SYSTEM_LIBS ${DUCKDB_SYSTEM_LIBS} ws2_32 rstrtmgr bcrypt)
 endif()
 
 if(OSX_BUILD_UNIVERSAL)
@@ -52,7 +52,7 @@ add_library(duckdb_odbc SHARED ${ALL_OBJECT_FILES}  duckdb_odbc.def)
 
 set_target_properties(duckdb_odbc PROPERTIES DEFINE_SYMBOL "DUCKDB_ODBC_API")
 target_link_libraries(duckdb_odbc ${LINK_LIB_LIST} ${LIBRARY_FILES})
-target_link_libraries(duckdb_odbc Threads::Threads ${LIB_DL})
+target_link_libraries(duckdb_odbc Threads::Threads ${DUCKDB_SYSTEM_LIBS})
 
 if(NOT CLANG_TIDY)
   add_subdirectory(test)