Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grant configs a no-op for DuckDB #459

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jwills
Copy link
Collaborator

@jwills jwills commented Oct 10, 2024

Fixes #458

@jwills jwills requested a review from guenp October 10, 2024 14:45
{% macro duckdb__apply_grants(relation, grant_config, should_revoke=True) %}
{#-- If grant_config is {} or None, this is a no-op --#}
{% if grant_config %}
{{ log("Grants are not (currently!) supported for DuckDB", info=True) }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ log("Grants are not (currently!) supported for DuckDB", info=True) }}
{{ log("Grants defined on relation ~ relation.render() ~ not (currently!) supported for DuckDB", info=True) }}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah this is a good call but I think it's missing some quotes in there-- will tweak it to include the relation info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tolerate grants in models
2 participants