rg_system: Disable all LED indicators except low battery by default (#…

…155) I've also added back a check for GPIO_NUM_NC.
ducalex · Sep 17, 2024 · d1ac0bb · d1ac0bb
1 parent 2def78b
commit d1ac0bb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/components/retro-go/rg_system.c b/components/retro-go/rg_system.c
@@ -191,7 +191,9 @@ static void update_indicators(void)
         ledColor = C_BLUE;
 
 #if defined(ESP_PLATFORM) && defined(RG_GPIO_LED)
-    gpio_set_level(RG_GPIO_LED, ledColor != 0);
+    // GPIO LED doesn't support colors, so any color = on
+    if (RG_GPIO_LED != GPIO_NUM_NC)
+        gpio_set_level(RG_GPIO_LED, ledColor != 0);
 #endif
 }
 
@@ -353,7 +355,7 @@ rg_app_t *rg_system_init(int sampleRate, const rg_handlers_t *handlers, const rg
         .configNs = RG_PROJECT_APP,
         .bootArgs = NULL,
         .bootFlags = 0,
-        .indicatorsMask = 0xFFFFFFFF,
+        .indicatorsMask = (1 << RG_INDICATOR_LOW_BATTERY),
         .speed = 1.f,
         .sampleRate = sampleRate,
         .tickRate = 60,

diff --git a/components/retro-go/rg_system.h b/components/retro-go/rg_system.h
@@ -92,7 +92,7 @@ typedef enum
 
 typedef enum
 {
-    RG_INDICATOR_PANIC = 0,
+    RG_INDICATOR_POWER = 0,
     RG_INDICATOR_LOW_BATTERY,
     RG_INDICATOR_CHARGING,
     RG_INDICATOR_DISK_ACTIVITY,