-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more regexp boiler plate reduction #29
Conversation
Whow, great simplification/maintenance stuff! Much easier to read for me, all that user_data stuff gone! |
Removed more explicit casts from void* in initializations of variables to the same type. This is not needed in c and potentially dangerous because it silently removes const. Even cases where it is "fine" hide (by their presence everywhere) the cases where something is really happening. This undermines the whole usefulness of const marking in the first place; we have structures containing const members that are always cast to non-const before use... c++ requires these casts, but checks they don't remove const and offers the (better) alternative of using templates to enforce the datatypes carried inside generic structures. |
c is channel
not needed in c and don't add safety or clarity. rather, by adding bulk, make code less readable and accesible (imho)
7a2ea00
to
04ae2e9
Compare
prep for gtk4
Rebasing creates a mess; opening new local PR |
improve consistency and reduce unnecessary duplication
@TurboGit @jenshannoschwalm @ralfbrown