Merge pull request #702 from ykuijs/release-2.0

Releasing v2.0

.codecov.yml

@@ -16,7 +16,7 @@ coverage:
   status:
     project:
       default:
-        # Set the overall project code coverage requirement to 70%
+        # Set the overall project code coverage requirement to 80%
         target: 80
     patch:
       default:

.vscode/RunGlobalTests.ps1

@@ -24,7 +24,7 @@ $result = Invoke-Pester -PassThru
 if ($result.FailedCount -gt 0) 
 {
     Write-Output -InputObject "Failed test result summary:"
-    $result.TestResult | Where-Object -FilterScript { 
+    $result.TestResult | Where-Object -FilterScript {
         $_.Passed -eq $false 
     } | ForEach-Object -Process {
         Write-Output -InputObject "-----------------------------------------------------------"

.vscode/RunPesterTests.ps1

@@ -21,7 +21,7 @@ else
 if ($result.FailedCount -gt 0) 
 {
     Write-Output -InputObject "Failed test result summary:"
-    $result.TestResult | Where-Object -FilterScript { 
+    $result.TestResult | Where-Object -FilterScript {
         $_.Passed -eq $false 
     } | ForEach-Object -Process {
         Write-Output -InputObject "-----------------------------------------------------------"

.vscode/launch.json

@@ -1,6 +1,29 @@
 {
     "version": "0.3.0",
     "configurations": [
+
+        {
+            "type": "PowerShell",
+            "request": "launch",
+            "name": "Run current unit test (SP2013)",
+            "script": "${file}",
+            "args": [
+                "${workspaceRoot}/Tests/Unit/Stubs/SharePoint/15.0.4805.1000/Microsoft.SharePoint.PowerShell.psm1"
+            ],
+            "cwd": "${file}",
+            "createTemporaryIntegratedConsole": true
+        },
+        {
+            "type": "PowerShell",
+            "request": "launch",
+            "name": "Run current unit test (SP2016)",
+            "script": "${file}",
+            "args": [
+                "${workspaceRoot}/Tests/Unit/Stubs/SharePoint/16.0.4456.1000/Microsoft.SharePoint.PowerShell.psm1"
+            ],
+            "cwd": "${file}",
+            "createTemporaryIntegratedConsole": true
+        },
         {
             "name": "Debug current file",
             "type": "PowerShell",

.vscode/settings.json

@@ -2,6 +2,17 @@
 {
     "powershell.scriptAnalysis.enable": true,
     "powershell.scriptAnalysis.settingsPath": ".vscode/ScriptAnalyzerSettings.psd1",
+    "powershell.codeFormatting.openBraceOnSameLine": false,
+    "powershell.codeFormatting.newLineAfterOpenBrace": false,
+    "powershell.codeFormatting.newLineAfterCloseBrace": true,
+    "powershell.codeFormatting.whitespaceBeforeOpenBrace": true,
+    "powershell.codeFormatting.whitespaceBeforeOpenParen": true,
+    "powershell.codeFormatting.whitespaceAroundOperator": true,
+    "powershell.codeFormatting.whitespaceAfterSeparator": true,
+    "powershell.codeFormatting.ignoreOneLineBlock": false,
+    "powershell.codeFormatting.preset": "Custom",
+    "files.trimTrailingWhitespace": true,
+    "files.insertFinalNewline": true,
     "files.exclude": {
         "**/.git": true,
         "**/.svn": true,

CHANGELOG.md

@@ -1,5 +1,147 @@
 # Change log for SharePointDsc
 
+## 2.0
+
+* General
+  * Added VSCode workspace settings to meet coding guidelines
+  * Corrected comment in CodeCov.yml
+  * Fixed several PSScriptAnalyzer warnings
+* SPAppManagementServiceApp
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPBCSServiceApp
+  * Added custom Proxy Name support
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPBlobCacheSettings
+  * Update to set non-default or missing blob cache properties
+* SPContentDatabase
+  * Fixed localized issue
+* SPDesignerSettings
+  * Fixed issue where URL with capitals were not accepted correctly
+* SPDistributedCacheService
+  * Fixed issue where reprovisioning the Distributed Cache
+    did not work
+* SPFarm
+  * Implemented ToDo to return Central Admin Auth mode
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPInstall
+  * Updated to document the requirements for an English ISO
+* SPInstallPrereqs
+  * Updated to document which parameter is required for which
+    version of SharePoint
+  * Added SharePoint 2016 example
+* SPLogLevel
+  * New resource
+* SPMachineTranslationServiceApp
+  * Added custom Proxy Name support
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPManagedMetadataAppDefault
+  * New resource
+* SPManagedMetadataServiceApp
+  * Update to allow the configuration of the default and
+    working language
+  * Fixed issue where the termstore could not be retrieved if the
+    MMS service instance was stopped
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPMinRoleCompliance
+  * New resource
+* SPPerformancePointServiceApp
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPProjectServer
+  * New resources to add Project Server 2016 support:
+  SPProjectServerLicense, SPProjectServerAdditionalSettings,
+  SPProjectServerADResourcePoolSync, SPProjectServerGlobalPermissions,
+  SPProjectServerGroup, SPProjectServerTimeSheetSettings,
+  SPProjectServerUserSyncSettings, SPProjectServerWssSettings
+* SPSearchContentSource
+  * Fixed examples
+* SPSearchIndexPartition
+  * Fixed to return the RootFolder parameter
+* SPSearchServiceApp
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPSearchTopology
+  * Updated to better document how the resource works
+  * Fixed issue to only return first index partition to prevent
+    conflicts with SPSearchIndexPartition
+* SPSecureStoreServiceApp
+  * Fixed issue with not returning AuditEnabled parameter in Get method
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPServiceAppSecurity
+  * Fixed issue with NullException when no accounts are configured
+    in SharePoint
+* SPStateServiceApp
+  * Added custom Proxy Name support
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPSubscriptionSettings
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPTrustedRootAuthority
+  * Updated to enable using private key certificates.
+* SPUsageApplication
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPUserProfileProperty
+  * Fixed two NullException issues
+* SPUserProfileServiceApp
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPUserProfileSynConnection
+  * Fix an issue with ADImportConnection
+* SPWeb
+  * Update to allow the management of the access requests settings
+* SPWebAppGeneralSettings
+  * Added DefaultQuotaTemplate parameter
+* SPWebApplicationExtension
+  * Update to fix how property AllowAnonymous is returned in the
+    hashtable
+* SPWebAppPeoplePickerSettings
+  * New resource
+* SPWebAppPolicy
+  * Fixed issue where the SPWebPolicyPermissions couldn't be used
+    twice with the exact same values
+* SPWebAppSuiteBar
+  * New resource
+* SPWebApplication.Throttling
+  * Fixed issue with where the RequestThrottling parameter was
+    not applied
+* SPWordAutomationServiceApp
+  * Fixed an issue where the instance name wasn't detected correctly
+* SPWorkflowService
+  * New resource
+
+The following changes will break 1.x configurations that use these resources:
+
+* SPAlternateUrl
+  * Added the Internal parameter, which implied a change to the key parameters
+* SPCreateFarm
+  * Removed resource, please update your configurations to use SPFarm.
+    See http://aka.ms/SPDsc-SPFarm for details.
+* SPJoinFarm
+  * Removed resource, please update your configurations to use SPFarm.
+    See http://aka.ms/SPDsc-SPFarm for details.
+* SPManagedMetadataServiceApp
+  * Changed implementation of resource. This resource will not set any defaults
+    for the keyword and site collection term store. The new resource
+    SPManagedMetadataServiceAppDefault has to be used for this setting.
+* SPShellAdmin
+  * Updated so it also works for non-content databases
+* SPTimerJobState
+  * Updated to make the WebAppUrl parameter a key parameter.
+    The resource can now be used to configure the same job for multiple
+    web applications. Also changed the Name parameter to TypeName, due to
+    a limitation with the SPTimerJob cmdlets
+* SPUserProfileProperty
+  * Fixed an issue where string properties were not created properly
+* SPUSerProfileServiceApp
+  * Updated to remove the requirement for CredSSP
+* SPUserProfileSyncService
+  * Updated to remove the requirement for CredSSP
+* SPWebAppAuthentication
+  * New resource
+* SPWebApplication
+  * Changed implementation of the Web Application authentication configuration.
+    A new resource has been added and existing properties have been removed
+* SPWebApplicationExtension
+  * Updated so it infers the UseSSL value from the URL
+  * Changed implementation of the Web Application authentication configuration.
+    A new resource has been added and existing properties have been removed
+
 ## 1.9
 
 * New resource: SPServiceIdentity

Modules/SharePointDsc/DSCResources/MSFT_SPAccessServiceApp/MSFT_SPAccessServiceApp.psm1

@@ -4,24 +4,24 @@ function Get-TargetResource
     [OutputType([System.Collections.Hashtable])]
     param
     (
-        [parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true)]
         [System.String]
         $Name,
 
-        [parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true)]
         [System.String]
         $ApplicationPool,
 
-        [parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true)]
         [System.String]
         $DatabaseServer,
 
-        [parameter(Mandatory = $false)] 
+        [Parameter()] 
         [ValidateSet("Present","Absent")] 
         [System.String] 
         $Ensure = "Present",
 
-        [parameter(Mandatory = $false)] 
+        [Parameter()] 
         [System.Management.Automation.PSCredential] 
         $InstallAccount
     )
@@ -42,15 +42,15 @@ function Get-TargetResource
             InstallAccount = $params.InstallAccount
         } 
         if ($null -eq $serviceApps) 
-        { 
+        {
             return $nullReturn 
         }
-        $serviceApp = $serviceApps | Where-Object -FilterScript { 
+        $serviceApp = $serviceApps | Where-Object -FilterScript {
             $_.GetType().FullName -eq "Microsoft.Office.Access.Services.MossHost.AccessServicesWebServiceApplication"            
         }
 
         if ($null -eq $serviceApp) 
-        { 
+        {
             return $nullReturn 
         } 
         else 
@@ -74,24 +74,24 @@ function Set-TargetResource
     [CmdletBinding()]
     param
     (
-        [parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true)]
         [System.String]
         $Name,
 
-        [parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true)]
         [System.String]
         $ApplicationPool,
 
-        [parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true)]
         [System.String]
         $DatabaseServer,
 
-        [parameter(Mandatory = $false)] 
+        [Parameter()] 
         [ValidateSet("Present","Absent")] 
         [System.String] 
         $Ensure = "Present",
 
-        [parameter(Mandatory = $false)] 
+        [Parameter()] 
         [System.Management.Automation.PSCredential] 
         $InstallAccount
     )
@@ -101,7 +101,7 @@ function Set-TargetResource
     $result = Get-TargetResource @PSBoundParameters
 
     if ($result.Ensure -eq "Absent" -and $Ensure -eq "Present") 
-    { 
+    {
         Write-Verbose -Message "Creating Access Services Application $Name"
         Invoke-SPDSCCommand -Credential $InstallAccount `
                             -Arguments $PSBoundParameters `
@@ -126,7 +126,7 @@ function Set-TargetResource
 
             $params = $args[0]
 
-            $app = Get-SPServiceApplication -Name $params.Name | Where-Object -FilterScript { 
+            $app = Get-SPServiceApplication -Name $params.Name | Where-Object -FilterScript {
                 $_.GetType().FullName -eq "Microsoft.Office.Access.Services.MossHost.AccessServicesWebServiceApplication"
             }
 
@@ -150,24 +150,24 @@ function Test-TargetResource
     [OutputType([System.Boolean])]
     param
     (
-        [parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true)]
         [System.String]
         $Name,
 
-        [parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true)]
         [System.String]
         $ApplicationPool,
 
-        [parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true)]
         [System.String]
         $DatabaseServer,
 
-        [parameter(Mandatory = $false)] 
+        [Parameter()] 
         [ValidateSet("Present","Absent")] 
         [System.String] 
         $Ensure = "Present",
 
-        [parameter(Mandatory = $false)] 
+        [Parameter()] 
         [System.Management.Automation.PSCredential] 
         $InstallAccount
     )