improve tests and increase code coverage

dsccommunity · Jan 14, 2022 · d58282a · d58282a
1 parent b7896c1
commit d58282a
Showing 1 changed file with 32 additions and 10 deletions.
diff --git a/tests/Unit/SharePointDsc/SharePointDsc.SPTrustedIdentityTokenIssuer.Tests.ps1 b/tests/Unit/SharePointDsc/SharePointDsc.SPTrustedIdentityTokenIssuer.Tests.ps1
@@ -569,19 +569,30 @@ try
                     }
 
                     Mock -CommandName Get-SPTrustedIdentityTokenIssuer -MockWith {
+                        return $null
+                    }
+
+                    Mock -CommandName New-SPTrustedIdentityTokenIssuer -MockWith {
                         $sptrust = [pscustomobject]@{
-                            Name              = $testParams.Name
-                            ClaimProviderName = $testParams.ClaimProviderName
+                            ImportTrustCertificate = $null
+                            Name                   = ""
+                            Description            = ""
+                            Realm                  = ""
+                            SignInUrl              = ""
+                            UseWReply              = ""
+                            ProviderSignOutUri     = ""
+                            IdentifierClaim        = ""
+                            ClaimsMappings         = $null
+                            ClaimProviderName      = ""
                         }
                         $sptrust | Add-Member -Name Update -MemberType ScriptMethod -Value { }
                         return $sptrust
                     }
                 }
 
-                It "Should create the SPTrustedLoginProvider with claims provider set" {
+                It "Should call cmdlet New-SPTrustedIdentityTokenIssuer" {
                     Set-TargetResource @testParams
-                    $getResults = Get-TargetResource @testParams
-                    $getResults.ClaimProviderName | Should -Be $testParams.ClaimProviderName
+                    Assert-MockCalled New-SPTrustedIdentityTokenIssuer
                 }
             }
 
@@ -615,19 +626,30 @@ try
                         }
 
                         Mock -CommandName Get-SPTrustedIdentityTokenIssuer -MockWith {
+                            return $null
+                        }
+
+                        Mock -CommandName New-SPTrustedIdentityTokenIssuer -MockWith {
                             $sptrust = [pscustomobject]@{
-                                Name              = $testParams.Name
-                                ClaimProviderName = $testParams.ClaimProviderName
+                                ImportTrustCertificate   = $null
+                                Name                     = ""
+                                Description              = ""
+                                RegisteredIssuerName     = ""
+                                AuthorizationEndPointUri = ""
+                                DefaultClientIdentifier  = ""
+                                SignOutUrl               = ""
+                                IdentifierClaim          = ""
+                                ClaimsMappings           = $null
+                                ClaimProviderName        = ""
                             }
                             $sptrust | Add-Member -Name Update -MemberType ScriptMethod -Value { }
                             return $sptrust
                         }
                     }
 
-                    It "Should create the SPTrustedLoginProvider with claims provider set" {
+                    It "Should call cmdlet New-SPTrustedIdentityTokenIssuer" {
                         Set-TargetResource @testParams
-                        $getResults = Get-TargetResource @testParams
-                        $getResults.ClaimProviderName | Should -Be $testParams.ClaimProviderName
+                        Assert-MockCalled New-SPTrustedIdentityTokenIssuer
                     }
                 }
             }