Skip to content

Commit

Permalink
Merge pull request #1351 from ykuijs/bugfix
Browse files Browse the repository at this point in the history
Bugfix
  • Loading branch information
ykuijs committed Nov 4, 2021
2 parents f4d64fa + 986b722 commit c1f1df4
Show file tree
Hide file tree
Showing 141 changed files with 117 additions and 483 deletions.
10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
application
- Added possibility to update application pool

### Changed

- SharePointDsc
- Updated build pipeline to use the correct vm image

### Fixed

- SharePointDsc
- Fixed issue where the snapin was generating the "An item with the same
key has already been added" error
- ReverseDsc
- Fixed issue where the export would contain duplicate configuration
- Fixed issue where the example export cmdlets was in the incorrect format
- SPDocIcon
- Fixed issue where the resource was using hardcoded SP2016 and later paths
and therefore didn't work in SP2013
- SPSearchServiceApp
- Fix SQL authentication support with updating DB ownership functions
- Disabled Farm account DB ownership updating functions when using SQL Auth
- SPServiceAppPool
- Fixed issue in Export method where the PsDscRunAsCredential was stored as
a string instead of a PsCredential object
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

$dociconPath = Join-Path -Path $env:CommonProgramFiles -ChildPath 'microsoft shared\Web Server Extensions\{0}\TEMPLATE\XML'
$iconPath = Join-Path -Path $env:CommonProgramFiles -ChildPath 'microsoft shared\Web Server Extensions\{0}\TEMPLATE\IMAGES'

$dociconFileName = 'DOCICON.XML'
$backupFileName = 'DOCICON_Backup_{0}.XML'

function Get-TargetResource
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

$Script:TrustLocationProperties = @(
"Address",
"LocationType",
Expand Down
3 changes: 0 additions & 3 deletions SharePointDsc/DSCResources/MSFT_SPFarm/MSFT_SPFarm.psm1
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

$script:resourceModulePath = Split-Path -Path (Split-Path -Path $PSScriptRoot -Parent) -Parent
$script:modulesFolderPath = Join-Path -Path $script:resourceModulePath -ChildPath 'Modules'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
3 changes: 0 additions & 3 deletions SharePointDsc/DSCResources/MSFT_SPFeature/MSFT_SPFeature.psm1
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
3 changes: 0 additions & 3 deletions SharePointDsc/DSCResources/MSFT_SPInstall/MSFT_SPInstall.psm1
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

$Script:SP2013Features = @("Application-Server", "AS-NET-Framework",
"AS-TCP-Port-Sharing", "AS-Web-Support", "AS-WAS-Support",
"AS-HTTP-Activation", "AS-Named-Pipes", "AS-TCP-Activation", "Web-Server",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
$script:SPDscUtilModulePath = Join-Path -Path $PSScriptRoot -ChildPath '..\..\Modules\SharePointDsc.Util'
Import-Module -Name $script:SPDscUtilModulePath

function Get-TargetResource
{
[CmdletBinding()]
Expand Down
Loading

0 comments on commit c1f1df4

Please sign in to comment.