Merge pull request #1412 from ahebx/master

SPUserProfileServiceApp: Fix issue where Get-TargetResource throws an error when no MySiteHost is specified
dsccommunity · Oct 31, 2022 · 9978e8c · 9978e8c
2 parents a98dfeb + 36fb015
commit 9978e8c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- SPUserProfileServiceApp
+  - Fixed issue where error 'You cannot call a method on a null-valued expression' was thrown when no MySiteHost was specified
+
 ## [5.2.0] - 2022-05-12
 
 ### Added

diff --git a/SharePointDsc/DSCResources/MSFT_SPUserProfileServiceApp/MSFT_SPUserProfileServiceApp.psm1 b/SharePointDsc/DSCResources/MSFT_SPUserProfileServiceApp/MSFT_SPUserProfileServiceApp.psm1
@@ -199,6 +199,7 @@ function Get-TargetResource
             $upMySiteLocation = $null
             $upMySiteManagedPath = $null
             $upSiteConflictNaming = $null
+            $mysiteHostLocation = $null
             try
             {
                 $ca = Get-SPWebApplication -IncludeCentralAdministration | Where-Object -FilterScript { $_.IsAdministrationWebApplication }
@@ -208,6 +209,10 @@ function Get-TargetResource
                 $upMySiteLocation = [System.Uri]$userProfileManager.MySiteHostUrl
                 $upMySiteManagedPath = $userProfileManager.PersonalSiteInclusion
                 $upSiteConflictNaming = $userProfileManager.PersonalSiteFormat
+                if (-not [string]::IsNullOrEmpty($upMySiteLocation.AbsoluteUri))
+                {
+                    $mysiteHostLocation = $upMySiteLocation.AbsoluteUri.TrimEnd('/')
+                }
             }
             catch
             {
@@ -223,7 +228,7 @@ function Get-TargetResource
                 Name                         = $serviceApp.DisplayName
                 ProxyName                    = $proxyName
                 ApplicationPool              = $serviceApp.ApplicationPool.Name
-                MySiteHostLocation           = $upMySiteLocation.AbsoluteUri.TrimEnd("/")
+                MySiteHostLocation           = $mysiteHostLocation
                 MySiteManagedPath            = $upMySiteManagedPath
                 ProfileDBName                = $databases.ProfileDatabase.Name
                 ProfileDBServer              = $databases.ProfileDatabase.NormalizedDataSource