feature request: make executor rescheduling configurable #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-louis-fruleux
changed the title
Comment on lines
-174
to
-183
| /** | ||
| * Schedule the task, and return a future. | ||
| * | ||
| * @deprecated Use {@link #getScheduledFuture(long, long, TimeUnit, Runnable, ScheduledExecutorService)} instead. | ||
| */ | ||
| @SuppressWarnings("DeprecatedIsStillUsed") | ||
| @Deprecated | ||
| protected ScheduledFuture<?> getScheduledFuture(long initialDelay, long period, TimeUnit unit, Runnable runnable) { | ||
| return getScheduledFuture(initialDelay, period, unit, runnable, this.executor); | ||
| } |
There was a problem hiding this comment.
I am aware this is a breaking change. Unfortunately, I did not find a way to make this function still relevant while passing the functional interface
Additionally, I think it is unlikely someone is overriding this method because it can make sense only with an executor.
What do you think?
Something obvious I missed in keeping this method for retro compatibility, while still making it relevant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
First of all, thanks for maintaining the project, we appreciate it.
We had an issue when using Grafana, actually, the exact same as described here: #2664
While having the possibility to override it is nice, we lose a lot of things by doing so, including the nice API builder on the graphite report.
The PR aims to make it configurable with the constructor.
Would that make sense to move forward with this PR?
Feel free to make any comments, long time I have not done any Java. I might not be aware of the good practices
PS: I made another PR proposition here, #4192. Which does not use lambdas and is maybe cleaner to read / maintain. What do you think?