Avoid sending larger-than-max array lengths over the wire #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids creating invalid messages, overflowing the array length, and having a length that doesn't match the element count. Slight downside that the user will have no way to know their messages are invalid (as a larger-than-max length should cause the receive side to reject the message assuming it does not overflow).
|
Tested that this branch works well with the quadplane-can simulated vehicle on ArduPilot master (2f0f7aa6). It flies and all the sensors work properly. |
tridge
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids creating invalid messages, overflowing the array length, and having a length that doesn't match the element count.
Slight downside that the user will have no way to know their messages are invalid (as a larger-than-max length should cause the receive side to reject the message assuming it does not overflow).