fix: Fix send congestion or send errors not causing connection shutdo…

…wn and leaking connections
driskell · Jul 30, 2024 · 02c8ede · 02c8ede
1 parent e453486
commit 02c8ede
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lc-lib/receiver/pool.go b/lc-lib/receiver/pool.go
@@ -137,7 +137,9 @@ ReceiverLoop:
 				expectedAck := r.connectionStatus[connection].progress[0]
 				expectedEvent := expectedAck.event
 				receiver := expectedEvent.Context().Value(transports.ContextReceiver).(transports.Receiver)
-				receiver.Acknowledge(expectedEvent.Context(), expectedEvent.Nonce(), expectedAck.sequence)
+				if err := receiver.Acknowledge(expectedEvent.Context(), expectedEvent.Nonce(), expectedAck.sequence); err != nil {
+					r.failConnection(expectedEvent.Context(), receiver, connection, err)
+				}
 				r.scheduler.Set(connection, time.Second*5)
 				r.connectionLock.Unlock()
 			}

diff --git a/lc-lib/transports/tcp/connection.go b/lc-lib/transports/tcp/connection.go
@@ -146,6 +146,10 @@ func (t *connection) senderRoutine() {
 	}()
 
 	t.senderErr = t.sender()
+	if t.senderErr != nil {
+		// Sender issue, close connections
+		t.shutdownFunc()
+	}
 }
 
 // sender handles socket writes