Set :poko-tests JVM toolchain version via CI
#311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewhamilton
commented
Feb 16, 2024
| val classVersionRegex = Regex("class version [\\d.]* \\((\\d*)\\)") | ||
| val actualClassVersion = classVersionRegex.find(this)!!.groups.last()!!.value.toInt() | ||
| if (actualClassVersion < version) { | ||
| throw AssumptionViolatedException("This test only works class version $version+") |
There was a problem hiding this comment.
Is there a canonical way to do this within the assertk framework? It seemed like maybe I'd need a custom FailureContext but that's all internal.
There was a problem hiding this comment.
drewhamilton
commented
Feb 16, 2024
Actually, it's more efficient now because we don't need to build the sample 4 times. |
drewhamilton
force-pushed
the
drew/test-jvm-toolchain-version
branch
from
bbc900c
to
2b0feab
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my understanding of the errors on #258, calling
jvmToolchainper-compilation in Kotlin Multiplatform is disallowed in Kotlin 2. This alternative makes the CI less efficient by needing to spin up more machines, but hopefully doesn't make it slower since the new machines are Ubuntu and will run in parallel to the main build. Happy to change the approach if there's a better way.