Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): data validation event trigger before data applied #3498

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 20, 2024

close https://github.com/dream-num/univer-pro/issues/2557
close https://github.com/dream-num/univer-pro/issues/2553
close https://github.com/dream-num/univer-pro/issues/2549

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  88353ac
info  For more information, see full report

@weird94 weird94 removed the qa:untested This PR is ready to be tested label Sep 20, 2024
@weird94 weird94 merged commit c4601a0 into dev Sep 20, 2024
9 checks passed
@weird94 weird94 deleted the fix/data-validation branch September 20, 2024 07:54
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 30.93%. Comparing base (7b89f27) to head (88353ac).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ata-validation/src/models/data-validation-model.ts 0.00% 5 Missing ⚠️
...lidation/src/models/sheet-data-validation-model.ts 0.00% 3 Missing ⚠️
...rollers/doc-thread-comment-selection.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3498      +/-   ##
==========================================
- Coverage   30.93%   30.93%   -0.01%     
==========================================
  Files        2159     2159              
  Lines      113354   113356       +2     
  Branches    24863    24864       +1     
==========================================
  Hits        35065    35065              
- Misses      78289    78291       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants