Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide sheet should operation right sheet #3468

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 18, 2024

close https://github.com/dream-num/univer-pro/issues/2468

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 18, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  b4a18f1
info  For more information, see full report

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.83%. Comparing base (4bc700b) to head (b4a18f1).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...on/sheet-permission-interceptor-base.controller.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3468      +/-   ##
==========================================
- Coverage   30.83%   30.83%   -0.01%     
==========================================
  Files        2158     2158              
  Lines      113186   113187       +1     
  Branches    24825    24825              
==========================================
  Hits        34897    34897              
- Misses      78289    78290       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested qa:rejected labels Sep 19, 2024
@ybzky ybzky merged commit a4bfe0d into dev Sep 19, 2024
9 checks passed
@ybzky ybzky deleted the fix-permission-hide-sheet branch September 19, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants