weather.sh: added timeouts to curl requests #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows for quitting early if wttr.in is having an issue. recently wttr.in had an issue where it would hang on requests, causing the status bar to fail.
If the last data that we received was actually an error message then we instead retry the connection every 1 minute until we get a valid status. This allows for faster recovery if the last check timed up with a network error.
|
Brilliant. Thanks. |
|
Hi @ethancedwards8. Please revert this PR as it completely breaks the weather display. |
mamantoha
reviewed
Oct 19, 2024
| main() | ||
| { | ||
| # process should be cancelled when session is killed | ||
| if timeout 1 bash -c "</dev/tcp/ipinfo.io/443" && timeout 1 bash -c "</dev/tcp/wttr.in/443"; then | ||
| echo "$(display_weather)$(display_location)" | ||
| if ! weather=$(timeout 3 bash -c "display_weather $fahrenheit"); then |
There was a problem hiding this comment.
$(display_location) is missing here.
Why $fahrenheit only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wttr.in occasionally has issues where requests hang, this can cause issues in the status bar.
changed the script so it exports defined functions and calls them in a sub-shell. This allows for use of the timeout command on bash functions.