[Mellanox] Change NVIDIA SDK build to cmake method #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic-slave-bookworm/Dockerfile.j2
Outdated
Comment on lines
427
to
428
| RUN sudo apt-get update -y | ||
| RUN sudo apt-get install -y libnl-genl-3-dev |
There was a problem hiding this comment.
not required. Verified it and removed. Also from "bullseye" slave docker
| PACKAGE_NAME = sys_sdk | ||
|
|
||
| $(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% : | ||
|
|
|
|
||
| $(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% : | ||
|
|
||
| # get sources |
There was a problem hiding this comment.
It is at the same place as previous SDK make files. Right above the treatment to get the sources so I don't see any issue with it.
platform/mellanox/mlnx-sai.mk
Outdated
| @@ -19,7 +19,7 @@ export MLNX_SAI_VERSION MLNX_SAI_SOURCE_BASE_URL | |||
|
|
|||
| MLNX_SAI = mlnx-sai_1.mlnx.$(MLNX_SAI_VERSION)_$(CONFIGURED_ARCH).deb | |||
| $(MLNX_SAI)_SRC_PATH = $(PLATFORM_PATH)/mlnx-sai | |||
| $(MLNX_SAI)_DEPENDS += $(MLNX_SDK_DEBS) $(LIBNL_ROUTE3_DEV) | |||
| $(MLNX_SAI)_DEPENDS += $(MLNX_SDK_DEBS) $(LIBNL3_DEV) $(LIBNL_GENL3_DEV) $(LIBNL_ROUTE3_DEV) $(LIBNL_NF3_DEV) | |||
There was a problem hiding this comment.
Verified that this is redundant so it was removed
|
|
||
| rm -rf builds/cmake | ||
|
|
||
| cmake -B builds/cmake -DPYTHON_INTERPRETERS=python3 -DSKIP_UNINSTALL_INSTALL_DEPENDENCY=on -DSKIP_DEPMOD_IN_INSTALL_PHASE=on -DUSE_API_TESTER=OFF -DUSE_KERNEL=OFF -DCMAKE_PROJECT_VERSION=$(MLNX_SDK_DEB_VERSION) |
There was a problem hiding this comment.
Does it account for SONIC_DEBUGGING_ON/SONIC_PROFILING_ON?
stepanblyschak
approved these changes
Apr 2, 2024
dprital
force-pushed
the
master_migrate_sdk_build_to_cmake
branch
from
59d4baf
to
f469e92
Compare
stepanblyschak
approved these changes
Aug 2, 2024
dprital
force-pushed
the
master_migrate_sdk_build_to_cmake
branch
from
c5f7fc6
to
c775e40
Compare
dprital
pushed a commit
that referenced
this pull request
Sep 5, 2024
…tically (sonic-net#20083) #### Why I did it src/sonic-dash-api ``` * 4919d9e - (HEAD -> master, origin/master, origin/HEAD) Allow `underlay_sip` to coexist with `vnet` in Route table (#27) (4 hours ago) [Lawrence Lee] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Up to now, building Mellanox SDK debian packages was done by "autotools" method.
Lately, Mellanox SDK team added the support to build by "cmake" method.
The benefit of using "cmake" is with decrease time of SDK build as "cmake" make it faster then "auto build".
When moving to "cmake" method, all SDK debians:
will be replaced by single debian - sys_sdk.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)