Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on strum (as unused) and bump strum_macros to 0.25 #29

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Nov 25, 2023

to switch dependency of syn from 1.* to 2.* version.

strum-macros new msrv is 1.56 (Peternator7/strum#261) but i can't find spdx-rs msrv, so this up to reviewer.

@klensy
Copy link
Contributor Author

klensy commented Nov 25, 2023

Funny thing: on my win machine there two failing tests, even on master branch:

---- parsers::test_super::file_info_is_retrieved stdout ----
thread 'parsers::test_super::file_info_is_retrieved' panicked at src\parsers\mod.rs:920:9:
assertion `left == right` failed
  left: Some("The concluded license was taken from the package level that the file was included in.\r\nThis information was found in the COPYING.txt file in the xyz directory.")
 right: Some("The concluded license was taken from the package level that the file was included in.\nThis information was found in the COPYING.txt file in the xyz directory.")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- parsers::test_super::spdx_creation_info_is_retrieved stdout ----
thread 'parsers::test_super::spdx_creation_info_is_retrieved' panicked at src\parsers\mod.rs:782:9:
assertion `left == right` failed
  left: Some("This package has been shipped in source and binary form.\r\nThe binaries were created with gcc 4.5.1 and expect to link to\r\ncompatible system run time libraries.")
 right: Some("This package has been shipped in source and binary form.\nThe binaries were created with gcc 4.5.1 and expect to link to\ncompatible system run time libraries.")


failures:
    parsers::test_super::file_info_is_retrieved
    parsers::test_super::spdx_creation_info_is_retrieved

…o 0.25

to switch dependency of syn from 1.* to 2.* version.
@mmurto
Copy link
Member

mmurto commented Nov 27, 2023

Thanks @klensy ! No real decision has been made on MSRV. I created an issue at #30, feel free to comment if you have thoughts. As 1.56 is decently old, I will release this without considering this a breaking change. Should decide on MSRV related matters before 1.0.0.

@mmurto mmurto merged commit 15c7140 into doubleopen-project:main Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants