define buffer api #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use editorconfig based on https://github.com/dotnet/aspnetcore/blob/main/.editorconfig
… buffer_queue_api # Conflicts: # src/Mocha.Core/Mocha.Core.csproj
liuhaoyang
reviewed
Oct 24, 2023
| { | ||
| IAsyncEnumerable<T> ConsumeAsync(CancellationToken cancellationToken = default); | ||
|
|
||
| ValueTask CommitAsync(); |
There was a problem hiding this comment.
commit 和 close 也需要传递CancellationToken吧？
There was a problem hiding this comment.
使用场景上，commit是在业务逻辑处理完后。如果没有没有正确的commit会导致重复消费，不太会有需要需要取消的场景。Close是表示当前Consumer被弃用了，如果存在取消close的场景，重新创建一个consumer会更清晰
|
|
||
| public interface IBufferQueue<T> | ||
| { | ||
| IBufferProducer<T> CreateProducer(); |
There was a problem hiding this comment.
producer 也需要一些参数，比如在队列溢出时是等待还是忽略
There was a problem hiding this comment.
目前的设计，队列不会溢出，只会扩容
liuhaoyang
reviewed
Nov 19, 2023
|
|
||
| namespace Mocha.Core.Buffer; | ||
|
|
||
| public class BufferOptionsBuilder |
| public MemoryBufferOptions AddTopic<T>(int partitionNumber) | ||
| { | ||
| _services.AddSingleton<IBufferQueue<T>>(new MemoryBufferQueue<T>(partitionNumber)); | ||
| return this; |
There was a problem hiding this comment.
可以考虑加一个 MemoryBufferQueueProvider 接口，MemoryBufferQueue 也可以使用 DI 来创建
There was a problem hiding this comment.
使用泛型的话，这里的 topic 和 数据类型绑定的吗？
如果Span 有创建N个Topic的场景就不能实现了
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.