Write CA1824 as non-compilation-end #6873
Conversation
Youssef1313
force-pushed
the
Ca1824-no-comp-end
branch
from
7fd5ab1
to
2073e40
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6873 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 1403 1403
Lines 330977 331006 +29
Branches 10890 10892 +2
=======================================
+ Hits 319055 319085 +30
+ Misses 9188 9187 -1
Partials 2734 2734 |
...ers/Core/Microsoft.NetCore.Analyzers/Resources/MarkAssembliesWithNeutralResourcesLanguage.cs
Show resolved
Hide resolved
| data.ApplicationSyntaxReference?.GetSyntax(context.CancellationToken) is { } attributeSyntax) | ||
| { | ||
| // we have the attribute but its doing it wrong. | ||
| context.ReportDiagnostic(attributeSyntax.CreateDiagnostic(Rule)); |
There was a problem hiding this comment.
❗ This diagnostic (the one with a specific location) should always be reported. It can set it should not return without reporting if alreadyReportedDiagnostic to true, butalreadyReportedDiagnostic was already true.
Edit: It cannot set alreadyReportedDiagnostic to true because it would destabilize the no-location reporting.
There was a problem hiding this comment.
Diagnostic with location will always be reported if we find a source assembly attribute here, otherwise a no-location diagnostic will always be reported - I believe the logic here is deterministic because data is computed at CompilationStart and does not alter during subsequent callbacks.
|
@sharwell I can merge once you are happy with the PR, thanks! |
|
Merging this PR - feel free to create a follow-up PR for any follow-up changes. |
The intent of this change is two things:
@mavasani @sharwell Do you think it's worth changing this analyzer to not be non-compilation-end (which will make it available in IDE live diagnostics)?
Is there a better than what I did here?