Refactor PropertiesShouldNotBeWriteOnlyAnalyzer (CA1044) #6871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Aug 20, 2023
|
|
||
| // not raising a violation for when: | ||
| // property is overridden because the issue can only be fixed in the base type | ||
| // property is the implementation of any interface member | ||
| if (property.IsOverride || property.IsImplementationOfAnyInterfaceMember()) | ||
| if (property.IsOverride || GetRule(property) is not DiagnosticDescriptor descriptor || property.IsImplementationOfAnyInterfaceMember()) |
There was a problem hiding this comment.
NOTE: The checks in GetRule were previously done after calling IsImplementationOfAnyInterfaceMember.
I think that checks in GetRule are a lot cheaper and can eliminate lots of properties. So this might slightly have a performance impact. This analyzer is generally fast enough though.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6871 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 1403 1403
Lines 330977 330975 -2
Branches 10890 10889 -1
=======================================
Hits 319055 319055
+ Misses 9188 9186 -2
Partials 2734 2734 |
mavasani
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.