Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CA1508 pragma suppressions #6832

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mavasani
Copy link
Contributor

@mavasani mavasani commented Aug 3, 2023

Closes #4520
Closes #4519

All these false positives have been fixed.

Closes dotnet#4520
Closes dotnet#4519

All these false positives have been fixed.
@mavasani mavasani requested a review from a team as a code owner August 3, 2023 11:36
@mavasani
Copy link
Contributor Author

mavasani commented Aug 3, 2023

@Youssef1313

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #6832 (61e8875) into main (95ab6bb) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6832   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files        1401     1401           
  Lines      330293   330291    -2     
  Branches    10845    10845           
=======================================
- Hits       318326   318325    -1     
+ Misses       9244     9242    -2     
- Partials     2723     2724    +1     

@mavasani mavasani merged commit 04a2571 into dotnet:main Aug 3, 2023
14 checks passed
@mavasani mavasani deleted the CA1508_Suppressions branch August 3, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA1508 false positive after a switch statement CA1508 false positive
2 participants