Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant column names collection from DataFrameColumnCollection #6701

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Remove redundant column names collection from DataFrameColumnCollection #6701

merged 1 commit into from
Jun 5, 2023

Conversation

asmirnov82
Copy link
Contributor

column names collection was used to get column name by column index. As DataFrameColumnCollection is already collection of columns that can be accessed by index - this[i].Name can be used instead to get name. Storing dedicated collection of names is excessive,

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@150e68f). Click here to learn what that means.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6701   +/-   ##
=======================================
  Coverage        ?   68.77%           
=======================================
  Files           ?     1215           
  Lines           ?   251723           
  Branches        ?    26256           
=======================================
  Hits            ?   173132           
  Misses          ?    71773           
  Partials        ?     6818           
Flag Coverage Δ
Debug 68.77% <100.00%> (?)
production 63.29% <100.00%> (?)
test 88.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...crosoft.Data.Analysis/DataFrameColumnCollection.cs 79.82% <100.00%> (ø)

@JakeRadMSFT
Copy link
Contributor

JakeRadMSFT commented May 20, 2023

@asmirnov82 thanks so much for all your contributions to DataFrame.

I’m on vacation but I can review in about a week and I’m the resident expert at the moment.

Would you be open to porting them to another branch?

#6664

I have a fairly big PR to modernize DataFrame to .NET 6 and Generic Math. If you could open a PR into that branch also… it would help a bunch.

@asmirnov82
Copy link
Contributor Author

Hi, @JakeRadMSFT. Many thanks for you quick response. I hope you're having a great time enjoying your vacation!

I created PR with porting all my changes to a new logic with general math. I also had to merge the latest main branch from the original machinelearning repo to avoid merging conflicts.

You may check, when you have time: https://github.com/JakeRadMSFT/machinelearning/pull/2/commits

@JakeRadMSFT
Copy link
Contributor

Hi, @JakeRadMSFT. Many thanks for you quick response. I hope you're having a great time enjoying your vacation!

I created PR with porting all my changes to a new logic with general math. I also had to merge the latest main branch from the original machinelearning repo to avoid merging conflicts.

You may check, when you have time: https://github.com/JakeRadMSFT/machinelearning/pull/2/commits

Thanks so much!

@michaelgsharp
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@michaelgsharp michaelgsharp merged commit 9590b07 into dotnet:main Jun 5, 2023
@asmirnov82 asmirnov82 deleted the remove_redundant_name_collection branch June 22, 2023 08:27
@JakeRadMSFT
Copy link
Contributor

Merged into Generic Math branch. (This is just a note for myself)

@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants