Skip to content

Commit

Permalink
update VS Code extension code for contract change, err response removal
Browse files Browse the repository at this point in the history
  • Loading branch information
jonsequitur authored and colombod committed Jun 13, 2023
1 parent c8a6492 commit a6395cf
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,3 @@ export function isNotebookSerializeResponse(arg: any): arg is commandsAndEvents.
&& typeof arg.id === 'string'
&& isUint8Array(arg.rawData);
}

export function isNotebookParserServerError(arg: any): arg is commandsAndEvents.NotebookErrorResponse {
return arg
&& typeof arg.id === 'string'
&& typeof arg.errorMessage === 'string';
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import * as commandsAndEvents from './polyglot-notebooks/commandsAndEvents';
import { MessageClient } from './messageClient';
import { isNotebookParserServerResponse, isNotebookParserServerError, isNotebookParseResponse, isNotebookSerializeResponse } from './interfaces/utilities';
import { isNotebookParserServerResponse, isNotebookParseResponse, isNotebookSerializeResponse } from './interfaces/utilities';
import { Eol } from './interfaces';
import * as constants from './constants';

Expand Down Expand Up @@ -39,8 +39,6 @@ export class NotebookParserServer {
}

return responseDocument;
} else if (isNotebookParserServerError(response)) {
errorMessage = response.errorMessage;
}
}

Expand All @@ -63,8 +61,6 @@ export class NotebookParserServer {
if (isNotebookParserServerResponse(response)) {
if (isNotebookSerializeResponse(response)) {
return response.rawData;
} else if (isNotebookParserServerError(response)) {
errorMessage = response.errorMessage;
}
}

Expand Down
4 changes: 0 additions & 4 deletions src/polyglot-notebooks/src/contracts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,6 @@ export interface NotebookSerializeResponse extends NotebookParserServerResponse
rawData: Uint8Array;
}

export interface NotebookErrorResponse extends NotebookParserServerResponse {
errorMessage: string;
}

// --------------------------------------------- Kernel events

export const AssemblyProducedType = "AssemblyProduced";
Expand Down

0 comments on commit a6395cf

Please sign in to comment.