Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET SDK to 9.0.100-rc.2.24464.3 #57887

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Updates the .NET SDK to version 9.0.100-rc.2.24464.3, which also updates the .NET runtime from version 9.0.0-rc.2.24456.9 to version 9.0.0-rc.2.24462.10.

This pull request was auto-generated by GitHub Actions.

Update .NET SDK to version 9.0.100-rc.2.24464.3.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot requested review from wtgodbe and a team as code owners September 16, 2024 12:12
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 16, 2024
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving SDK update.

Copy link
Contributor

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 19, 2024

@ellahathaway the generated prebuilt-usage.xml file doesn't list any File for the 2 new Prebuilts (Newtonsoft.json 13.0.1 & System.Security.Cryptography.Xml 6.0.0), is there another way to figure out where they're coming from?

@ellahathaway
Copy link
Member

ellahathaway commented Sep 19, 2024

@ellahathaway the generated prebuilt-usage.xml file doesn't list any File for the 2 new Prebuilts (Newtonsoft.json 13.0.1 & System.Security.Cryptography.Xml 6.0.0), is there another way to figure out where they're coming from?

[Edited]

These prebuilts are quite odd. I can't find them in the binlogs, although they end up in the source-build package cache somehow (but this only shows up in the outer binlog when reporting on the prebuilts).

My hunch is that these dependencies are somehow being pulled from either an intermediate or the toolset, although when I look at the binlogs, I don't see these dependencies listed in the intermediates or toolset. I've asked @MichaelSimons to help me take a look.

Heads up that we are both OOF tomorrow, so if you need additional help with these before the weekend please ping someone via @dotnet/source-build-internal.

@ellahathaway
Copy link
Member

We think the path forward here is to add these to the prebuilt exclusion baseline.

For context, we suspect that these are transitive dependencies of packages being referenced in aspnetcore. For example, Nuget.Packaging.6.2.4 is referenced in this repo and has Newtonsoft.Json.13.0.1 as a dependency. Given that Nuget.Packaging will get lifted to the latest version during a VMR source-build build, we suspect that Newtonsoft.Json will also get lifted to 13.0.3.

These prebuilts likely surfaced now due to changes in how nuget handles transitive dependencies, but we aren't entirely sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants